Fix s3.get_subdevices() - Githubissues

mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs

MIT License

1.35k stars 477 forks source link

Fix s3.get_subdevices() #790

Closed felipediel closed 2 months ago

felipediel commented 2 months ago

Context

Bug report: https://github.com/mjg59/python-broadlink/pull/754.

Proposed change

Improve s3.get_subdevices() logic:

Make "step" a parameter;
Use a set to ignore duplicate devices;
Leverage on resp["total"] to break the loop before the time (more efficient);
Improve logic if len(seen) == total -> if len(seen) >= total.

Thanks @stevendodd!

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New device
[ ] New product id (the device is already supported with a different id)
[ ] New feature (which adds functionality to an existing device)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation

Additional information

This PR fixes issue: fixes #
This PR is related to:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[x] The code has been formatted using Black.
[x] The code follows the Zen of Python.
[x] I am creating the Pull Request against the correct branch.
[ ] Documentation added/updated.