mjgardes / seltzer

CRM for hackerspaces
GNU General Public License v3.0
4 stars 5 forks source link

More than one active plan should not be allowed. #42

Open myself248 opened 6 years ago

myself248 commented 6 years ago

Just had some strange behavior in a report caused by a member who had a hiatus plan which didn't have an end date (which it should have!), and then also had a regular membership plan, which also didn't have an end date (good, cuz they're a current member).

I don't think this condition can ever be proper. When starting a new plan, other plans should be ended (on the same date the new plan starts? or on the day before?).

rumplestilzken commented 9 months ago

I have confirmed this is still the case. Would you like me to take care of it?

myself248 commented 9 months ago

I'm in no position to make such a call as I no longer work with seltzer directly, so I'll defer to others' judgment.

rumplestilzken commented 8 months ago

I have put in a fix for this bug, a future enhancement should be considered to have a history of memberships and allow for memberships to be added to kick in in the future, automatically ending the current active membership.

rumplestilzken commented 8 months ago

Fixed by PR #62