mjhas / postfix

puppet postfix module
Other
5 stars 21 forks source link

Parameters #5

Closed andyleejordan closed 10 years ago

andyleejordan commented 10 years ago

This is #4 without the last commit containing the hiera_hash function.

andyleejordan commented 10 years ago

Perhaps we should also remove the create_resources for mastercfs. There's been a lot of talk other places about restricting create_resources(thing, hiera_hash(hash_of_things)) to profiles (per this design suggestion. I'm contemplating how I'd mix that design in with my current one. I really like the creation of resources from a Hiera hash, because that coupled with inclusion of classes in Hiera, let's me specify all my node-level logic in YAML. My site manifest is pretty barebones, but note that I already use create_resources in there. My current thought is moving all create_resources from modules and into loose profiles in my site manifest. If I could find a way to abstract create_resources(thing, hiera_hash(hash_of_things)) with hash of thing: hash_of_things, oh man, I'd be golden (like a function that given resource names and corresponding hash names, would create create_resources in that manner). Thoughts?

mjhas commented 10 years ago

well you can create such a function you just need a key in your hash to pin down the type of resource you want.