search

mjhas / postfix

puppet postfix module
Other
5 stars 21 forks source link

Add ldap support #9

Closed cypherfox closed 10 years ago

cypherfox commented 10 years ago

provides a class to add basic ldap support to postfix server and a defined type to add ldap maps.

mjhas commented 10 years ago

looks nice. though it seems the stdlib cloned into the fixtures module_path is not used and only the build path is used: module_path:/home/travis/build/mjhas

cypherfox commented 10 years ago

The stdlib is required for the 'validate_*' functions in ldap_map (around line 53).

I will check why the test is not working. Please stay tuned

cypherfox commented 10 years ago

I just checked: I have switched back to using 'puppetlabs_spec_helper/module_spec_helper' in my master, which you have commented out. In my module the repo carries a 'puppet-' name prefix, so I cannot use the super-directory as a module path as you can. This did not cause a problem with my other changes, as they did not require additional modules (at least not in the tests). I did not include the change to the testing infrastructure in the PR as I did not know why you commented out the puppetlabs spec helper. Any ideas?

mjhas commented 10 years ago

well, a intermediate solution would be to clone the stdlib version in the .travis.yml, although that is definitely a hack ;) I will have a closer look into puppetlabs_spec_helper/module_spec_helper

mjhas commented 10 years ago

puppetlabs_spec_helper/module_spec_helper in spec/spec_helper.rb and commenting out the following line c.module_path = File.expand_path(File.join(__FILE__, '../../../')) should do the trick.

cypherfox commented 10 years ago

If you are fine with using the puppetlabs_spec_helper, I can set up the whole testing to do that. The cloning of stdlib can be done with the PL spec helper, even to be used for the 'puppet apply' smoke test. I am twiddling with that in my master and will backport it to the ldap branch if you are fine with it.

Currently the proper setup of the Augeas fixtures is giving be grief, but I can fix that in the next couple of days.

mjhas commented 10 years ago

Using the puppetlabs_spec_helper is fine with me and your backport is definitely appreciated.

PS: I can only agree with the augeas fixtures ;)

cypherfox commented 10 years ago

Finally! Got the puppetlabs helper and augeas to work.

mjhas commented 10 years ago

awesome!