search

mjhoptics / ray-optics

geometric ray tracing for optical systems
BSD 3-Clause "New" or "Revised" License
263 stars 54 forks source link

SequentialModel reset #63

Closed asebian closed 2 years ago

asebian commented 2 years ago

Dear Mr. Hayford, I came accross a minor error.

In file seq/sequential.py in function reset() at line 117:

self.__init__()

Throws an error because constructor gets called without the required argument. I guess it should be

self.__init__(self.opt_model)

I'm a mere hobbyist and have just started trying out your library. Thanks a lot for sharing it!

Cheers!