mjhoptics / ray-optics

geometric ray tracing for optical systems
BSD 3-Clause "New" or "Revised" License
263 stars 54 forks source link

Problem importing zmx lens #84

Closed ppfromero closed 2 years ago

ppfromero commented 2 years ago

Hello,

Before all, thanks for this great package! I'm trying to import zmx file from Edmund web site

https://www.edmundoptics.com/p/25mm-diameter-x-40mm-efl-aspherized-achromatic-lens/10169/


              r            t        medium     mode   zdr      sd
  Obj:     0.000000  1.00000e+10       air             1  4.2787e+08
 Stop:    24.800000      9.00000   S-BSM14             1      12.500
    2:   -37.600000      2.50000   S-TIH53             1      12.500
    3:  -135.000000    0.0800000   517.520             1      12.500
    4:  -102.337111      33.4660       air             1      12.500
  Img:     0.000000      0.00000                       1      1.7157

The material are not well imported: Materials are: ELEMENT A: N-SK14 ELEMENT B: N-SF57

I have some errors in log file

INFO:root:Line 4: Command MODE not supported
INFO:root:Line 6: Command PFIL not supported
INFO:root:Line 7: Command LANG not supported
INFO:root:Line 10: Command ENVD not supported
INFO:root:Line 11: Command GFAC not supported
INFO:root:Line 13: Command SDMA not supported
INFO:root:Line 16: Command ROPD not supported
INFO:root:Line 18: Command PICB not supported
INFO:root:Line 25: Command PWAV not supported
INFO:root:Line 26: Command GLRS not supported
INFO:root:Line 27: Command COFN not supported
INFO:root:Line 29: Command FIMP not supported
INFO:root:Line 35: Command COMM not supported
INFO:root:Line 37: Command FIMP not supported
INFO:root:Line 40: Command COAT not supported
INFO:root:Line 47: Command FIMP not supported
INFO:root:Line 56: Command FIMP not supported
INFO:root:Line 66: Command FIMP not supported
INFO:root:Line 82: Command FIMP not supported

Thanks for your support

mjhoptics commented 2 years ago

It appears that the lens files contain the Ohara equivalent glasses to the Schott glasses listed on the product page.

The log files lists commands that are not recognized/processed. Commands like COAT for coating are not supported by ray-optics. Others, I don't know what they are, but they don't seem to be critical to the lens definition.

Regards Mike

ppfromero commented 2 years ago

Ok thanks Mike for your help!! regards