search

mjhouse / ag-lcd

A rust port of the C++ LiquidCrystal library for arduino systems
GNU General Public License v3.0
17 stars 8 forks source link

Add uno example for printing two lines #13

Closed vcrn closed 2 years ago

vcrn commented 2 years ago

This is another example running on Arduino Uno. Since all of the main.rs files of the Nano examples seem to run on the Uno without any modifications, it felt a bit redundant to copy-paste one of the examples already available. This example shows how you can write text on both lines of an LCD as well as how you can implement your own method on the struct LcdDisplay.

I also updated the examples/README to inform about some users experiencing issues with initializing their LCD using the Uno, linking to the open issue.

What do you think?

vcrn commented 2 years ago

I probably won't be able to contribute any code during the coming month or so, but I'll get your comments resolved as soon as I'm back.

I'll be available via email and github though, if you want to discuss something.

vcrn commented 2 years ago

I was able to keep working on this PR much sooner than I expected. I've made your suggested changes. and also updated the relative paths of the nano/examples to ag-lcd since they were no longer working because of the new subdirectory nano/. I also updated the license of the Uno-examples so they match that of the crate.

What do you think? And if you've changed your mind regarding the impl PrintTwoLines and want to go with what you first suggested, that's fine with me.

vcrn commented 2 years ago

No problem at all! Less than 24 hours is nothing to complain about