search

mjhouse / ag-lcd

A rust port of the C++ LiquidCrystal library for arduino systems
GNU General Public License v3.0
17 stars 8 forks source link

Merging LcdDisplay implementations #32

Closed mjhouse closed 1 year ago

mjhouse commented 1 year ago

During review of a PR, @JohnTheCoolingFan and I discussed merging the two implementations of LcdDisplay by relaxing the requirements on the output pins. This issue is to investigate that and see if it's possible, then implement it if it is.

JohnTheCoolingFan commented 1 year ago

Well, first thing that needs to be adressed is Error type being required to be Infallible. If the requirement of the Error type could be relaxed or removed completely that would make it easy to improve and merge. So the question is: does it need to be Infallible? As far as I've seen errors are ignored mostly, no unwraps or other stuff.

mjhouse commented 1 year ago

It might have been a holdover from a previous version of the lib. I honestly can't remember.