search

mjhouse / ag-lcd

A rust port of the C++ LiquidCrystal library for arduino systems
GNU General Public License v3.0
17 stars 8 forks source link

Relax requirements of OutputPin error type #33

Closed JohnTheCoolingFan closed 1 year ago

JohnTheCoolingFan commented 1 year ago

Resolves #32

All I did is removed requirement of OutputPin<Error = Infallible> and removed the wrapper pin in i2c module.

Making i2c impl blocks more generic wouldn't work (and probably would have no benefit) since both supported i2c expanders have the same Pin struct.

mjhouse commented 1 year ago

@JohnTheCoolingFan You built and ran this?

JohnTheCoolingFan commented 1 year ago

Well, building the library itself doesn't produce any errors, I'll try on a test project

JohnTheCoolingFan commented 1 year ago

Works fine on i2c test project

mjhouse commented 1 year ago

Works fine on i2c test project

Cool. I'll merge it.