search

mjhouse / deaf

A library for inspecting/modifying ELF binaries
GNU General Public License v3.0
7 stars 0 forks source link

Combine array structs #17

Closed mjhouse closed 1 year ago

mjhouse commented 1 year ago

As far as I can tell, init, preinit and fini are exactly the same and can be combined. The only difference is the SHType that they need to look for inside of the TryFrom<SectionHeader> implementations. They can probably be combined.

mjhouse commented 1 year ago

Mostly resolved in 1810f09394ed94e333015174c59556f4c6bfe03c. Need to clean up the methods to return i64 instead of Item<i32,i64> and then uncomment and verify that tests still run.

mjhouse commented 1 year ago

Array is fully implemented in 338a9745d41add8ced596e993be810c599d37068 and has a custom ArrayItem struct that wraps the Item struct.