search

mjhydri / 1D-StateSpace

This repository contains the implementation of an efficient joint beat, downbeat, tempo, and meter tracking system using a compact 1D probabilistic state space and a jump-back reward technique. ICASSP 2022.
MIT License
66 stars 13 forks source link

Tempo off by 5 consistently #2

Open akhudek opened 1 year ago

akhudek commented 1 year ago

Hi Mojtaba,

I was trying out your package but find that the reported tempo is off consistently by 5. The easiest test of this is to use 808kick120bpm.mp3 from the beatnet package, though I found the same thing with another music sample. Beatnet reports the. correct tempo.

Any idea what might cause this?

Best, Alex

clementabary commented 9 months ago

Hi, I'm also trying to make the package work but it doesn't seem so even on 808kick120bpm.mp3. I get:

# Ex: RUN 1
array([[  4.02,   1.  , 130.  ,   4.  ],
       [  4.52,   2.  , 115.  ,   4.  ],
       [  5.02,   2.  , 125.  ,   4.  ],
       [  5.54,   2.  , 111.  ,   4.  ],
       [  6.04,   1.  , 115.  ,   4.  ],
       [  7.14,   2.  , 115.  ,   4.  ],
       [  8.24,   2.  , 120.  ,   4.  ],
       [  9.34,   2.  , 115.  ,   4.  ]])

# Ex: RUN 2
array([[  4.02,   1.  , 107.  ,   4.  ],
       [  4.52,   2.  , 115.  ,   4.  ],
       [  5.02,   2.  , 125.  ,   4.  ],
       [  6.12,   2.  , 125.  ,   4.  ],
       [  7.22,   1.  , 107.  ,   4.  ],
       [  8.32,   1.  , 125.  ,   4.  ],
       [  9.42,   1.  , 107.  ,   4.  ]])

Beat times are clearly off/missing, plus results are different at each run actually. I wonder if someone took a dive in the code and found a quick fix?

EDIT: I moved my comment to a new issue.