mjirv / dbt-datamocktool

A dbt package for unit testing your SQL analytics models
Apache License 2.0
162 stars 20 forks source link

feat: Support multiple test cases #56

Open marcellovictorino opened 1 year ago

marcellovictorino commented 1 year ago

This is a:

Description & motivation

Addressing this issue, enables to define a test once, to be applied over multiple test cases.

Applicable when there are multiple test case scenarios, where the mocked input and expected output data (seed) represent a single case, having the seed file names identified by test_case_1, test_case_2 etc.

Checklist

Additional comments

Splitting the original PR into two separate ones: this one focus on enabling multiple test cases within a single test definition

marcellovictorino commented 1 year ago

@mjirv as requested, splitting the original into separate PRs I will hold on the second PR, saving the mocked model output as view for improved error visibility, for later 👍 I will even create an issue for it

marcellovictorino commented 1 year ago

@mjirv bumping for visibility Thanks!

mjirv commented 1 year ago

@marcellovictorino thanks for bumping! I had missed that you updated this. Reviewing now!

marcellovictorino commented 1 year ago

@mjirv Thanks for the new review! It has been a busy week. But I am interested in applying the fixes and trying to create the end-to-end test. Might take a bit longer, but would be a learning opportunity for me, and hopefully easier for future contributions 😅 🎉 I will aim to complete this before the end of this week (4th November)

mjirv commented 1 year ago

@marcellovictorino awesome, let me know if you need anything!