Closed LeopoldGabelmann closed 1 year ago
This is awesome, thanks for submitting this! I'll take a closer look later this week.
No rush at all here! We probably have to tinker around a little bit to make it compatible with the overall idea of your repo, however, I won't have any time for that until next week ;)
This looks really good. I requested a few changes.
What version of dbt did you test this on? I couldn't get it to run without qualifying macro names with the name of the package, which makes me think we're using different versions...
Thanks for the feedback. I'll look into it this week and will let you now as soon as I have adapted the code accordingly. I just did an update to the newest dbt version and am now running on 1.4.1. and the code does not work at the moment. I'll try to get this running on this version. @mjirv Does that work for you?
Edit: I actually found some time today and continued my work, now using v1.4.1. They had a change, however, in their model node keys so that I had to change a line in the dmt_get_test_sql.sql file that otherwise has nothing to do with this PR.
This is a:
Description & motivation
The standard unit test is only comparing the entire table and telling you at the end that the contents do not match. However, they error message does not point out the column with the different values. By adding some macros inspired by the dbt original unit test one can compare the columns with each other and that way can easily see what actually caused the error. That speeds up debugging a lot.
Checklist