search

mjisaak / skilling-champion-extension

Skilling Champion extension 🐱‍👤
MIT License
40 stars 10 forks source link

Added support for learn.microsoft.com #32

Closed LinnZawWin closed 2 years ago

LinnZawWin commented 2 years ago

docs.microsoft.com has been changed to learn.microsoft.com

mjisaak commented 2 years ago

Hi @LinnZawWin,

Thank you for your contribution 👋. I have written Microsoft asking if learn.microsoft.com is tracked by the Skilling Champion program. I expect and hope that this is the case. If so, I will be happy to accept your pull request and release the version to the marketplaces.

Best regards, Martin

flcdrg commented 2 years ago

I've just been chatting with Shiva Ford from Microsoft about this and she confirmed that 'learn.microsoft.com' should be included.

LinnZawWin commented 2 years ago

Awesome... Thanks.

flcdrg commented 2 years ago

@LinnZawWin why did you close this? Don't you want to allow it to be merged?

LinnZawWin commented 2 years ago

@flcdrg My bad. I pressed the wrong button "Close with comment" instead of the "Comment" button. 😅

mjisaak commented 2 years ago

I created a new release v1.4.6 containing your changes and uploaded it to the marketplaces.