mjishnu / pypdl

A concurrent pure python downloader with resume capablities
https://pypi.org/project/pypdl/
MIT License
44 stars 8 forks source link

Add proxy usage and make filename optional or directory #7

Closed AndryS0 closed 9 months ago

AndryS0 commented 9 months ago

Thank you so much for your library, it is very useful for me. But there are a few things I would like to correct:

  1. The name of the downloaded file is often unknown to the user and is obtained via a HEAD request. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition So I thought it would be permissible to make filepath optional or folder, so that the user side doesn't have to do an overhead like another HEAD request. This would then generate the file name with Content-Disposition taken into account.
  2. No proxy or authorization was used for the HEAD request, which can cause problems in some cases
mjishnu commented 9 months ago

changes needed

mjishnu commented 9 months ago

I am merging this and making necessary changes. thanks for the PR btw