search

mjk2244 / pro-football-reference-web-scraper

Web scraper to retrieve player and team data from Pro Football Reference.
https://mjk2244.github.io/pro-football-reference-web-scraper/
Apache License 2.0
28 stars 19 forks source link

Fix blank cell data #55

Closed ingoldsby closed 11 months ago

ingoldsby commented 11 months ago

Some lines for QB and RB players have had blank cells instead of having a default of 0. This PR corrects that and enters an entry of 0 instead.

codecov-commenter commented 11 months ago

Codecov Report

Merging #55 (1ac3a14) into main (094fa5c) will increase coverage by 1.88%. Report is 3 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   92.54%   94.42%   +1.88%     
==========================================
  Files           6        6              
  Lines         322      323       +1     
  Branches       61       61              
==========================================
+ Hits          298      305       +7     
+ Misses         11        9       -2     
+ Partials       13        9       -4
Files Coverage Δ
..._football_reference_web_scraper/player_game_log.py 96.77% <100.00%> (+4.90%) :arrow_up:
...ro_football_reference_web_scraper/team_game_log.py 91.46% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ingoldsby commented 11 months ago

There are potentially one or two other areas that could pre-emptively be amended in case there are other blank cells that cause issues, but I have not run across them myself as yet so left them alone. For example: wr_game_log