search

mjkaufer / JSML

:scroll: Dynamic, JSON powered HTML
34 stars 1 forks source link

Fixed TODO.md link #11

Closed 2016rshah closed 9 years ago

2016rshah commented 9 years ago

The link was broken because it was a relative path.

phikal commented 9 years ago

Wasn't it because the TODO.md was moved from the root directory to /doc/?

Shouldn't /doc/TODO.md be enough?

2016rshah commented 9 years ago

I'm not sure I just tried to click it and it didn't work so I found the actual file and put that link in. It should work this way unless there is a reason you do not want to use the full link?

phikal commented 9 years ago

The problem is that if the link were opend in a different repository that @mjkaufer's, it would still send you to his TODO.MD file instead of the repositories.

2016rshah commented 9 years ago

How's this?

phikal commented 9 years ago

That's what I meant. No reason not to approve since it is broken after all.

mjkaufer commented 9 years ago

Should it be doc/TODO.MD instead of /doc/TODO.MD?

2016rshah commented 9 years ago

Either will work because the README is inside the root directory for the repo.

mjkaufer commented 9 years ago

So it's fine for GitHub but, if someone tries to clone the repo locally and view the readme, it will not work. If you could fix all the links to relative links (no leading /), that would be great.

2016rshah commented 9 years ago

I don't know who clicks links and expects them to work locally but for everybody out there who does it should work now haha

mjkaufer commented 9 years ago

Thanks