Closed phikal closed 9 years ago
Looks awesome. Thanks for contributing!
Hey @phikal - there are some problems with your PR.
Basically, some errors I noticed:
id
attributes with no corresponding values in the rendered HTML, despite these values being outlined in the JSMLHowever, I really like how you organized the code and made it better from a command line view. There are just some errors with your modifications to the compiler that break stuff.
I would try reverting the major changes to the compiler - i.e., leave handleArray
alone. What you did with the parser worked excellently. If you would send a new PR with the parser code, etc., we can integrate that and, then, we can work together on implementing things such as shortened tags, etc.
Also, I'd rather have the project called JSML
as opposed to JSMLC
- that's just personal preference, sorry.
Thanks again for your help!
I will do that, I realized I had a few uncommitted changes too. Be back soon.
Awesome!
I implemented a few features from the TODO file:
jsml -c [file]
And general optimisation here and there. I had to add an optparse libary, which makes up most of the commits new lines.
Edit: Forgot to mention that I added short-tags:
tag
can be written witht
,attributes
witha
,text
withT
andchildren
withc
. Longer tags have a higher priority.