mjl- / mox

modern full-featured open source secure mail server for low-maintenance self-hosted email
https://www.xmox.nl
MIT License
3.36k stars 89 forks source link

Minor issue: Slightly incorrect helptext for Host TLSRPT #182

Closed mdavids closed 1 week ago

mdavids commented 2 weeks ago

This line is generic: https://github.com/mjl-/mox/blob/ac3596a7d7bf5f5e86b665b1ac06afc5aac9e430/webadmin/admin.go#L1219

But for a Host TLSRPT it could be wrong.

For example; if the host is mx.example.nl is should say:

Ensure a DNS TXT record like the following exists:

    _smtp._tls.mx TXT "v=TLSRPTv1; rua=mailto:tls-reports@mx.example.nl"

Now it only says _smtp._tls

mjl- commented 1 week ago

thanks for reporting! i fixed this record, and made a few others absolute too (they should all be absolute now, matching how they're shown on the page with required dns records).

i still want to split up the records into those that cover only the mail host vs only the host... it's on a todo list.

closing this issue, feel free to reopen if there's more to do.