search

mjmlio / atom-mjml-preview

MJML preview in Atom
https://atom.io/packages/mjml-preview
MIT License
20 stars 4 forks source link

Saving once closes the preview, saving again opens it again #15

Closed gdavalos closed 6 years ago

gdavalos commented 6 years ago

This problem began recently so it might be because of some recent atom update.

Steps to reproduce:

  1. Open a mjml file and open the preview
  2. Make some changes and save, this will close the preview
  3. Save again and the preview will open again
RDumais commented 6 years ago

I am having the same issue.

ngarnier commented 6 years ago

Hi, thanks for reporting the issue @gdavalos & @RDumais, I could reproduce. I did not notice it initially as I had disabled the auto-preview on save.

Indeed it must be related to an Atom update... we'll have to dig into it.

eek4ever commented 6 years ago

@ngarnier, Hi! I have the same problem. Please fix it

ngarnier commented 6 years ago

hey @eek4ever, we've got a lot going on with MJML 4 in the pipe. Any help with this issue would be appreciated, feel free to look into it and share anything you find!

ngarnier commented 6 years ago

This is fixed in the latest version of the package.

eek4ever commented 6 years ago

Thank you, man! Your product is awesome!

Sent from my iPhone

On 12 Apr 2018, at 10:54, Nicolas Garnier notifications@github.com wrote:

This is fixed in the latest version of the package.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.