search

mjmlio / atom-mjml-preview

MJML preview in Atom
https://atom.io/packages/mjml-preview
MIT License
20 stars 4 forks source link

Promise.done is deprecated. #2

Closed manicmarvin closed 7 years ago

manicmarvin commented 7 years ago

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1214:5)
Object.openPane (/Users/marvin/.atom/packages/mjml-preview/lib/mjml-preview.js:73:72)
<unknown> (/Users/marvin/.atom/packages/mjml-preview/lib/mjml-preview.js:41:17)
Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
TextBuffer.saveAs (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1144:27)
gnegreiros commented 7 years ago

Same issue.

JeffCleverley commented 7 years ago

same issue

pgallar commented 7 years ago

Same issue

Atn-D commented 7 years ago

Same issue.

ngarnier commented 7 years ago

Thanks for opening this issue and adding in guys, it should be fixed by updating to the latest version

benjaminsehl commented 6 years ago

This is popping up again after updating to 2.0.0

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done - <embedded>:1681:9
<unknown> - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:84:12
Object.openPane - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:87:9
<unknown> - /Users/homefolder/.atom/packages/mjml-preview/lib/mjml-preview.js:41:17
Function.module.exports.Emitter.simpleDispatch - <embedded>:66277:20
Emitter.emit - <embedded>:66393:34

Is there something special I should be doing when updating?

ngarnier commented 6 years ago

hey @benjaminsehl, we reintroduced that in an update of the package, but you can ignore it, it's just a warning (it won't lead to any error). We'll fix it in a future release.