search

mjmlio / atom-mjml-preview

MJML preview in Atom
https://atom.io/packages/mjml-preview
MIT License
20 stars 4 forks source link

Preview shows as blank in atom 1.47 for Mac #23

Closed bvonhalle closed 4 years ago

bvonhalle commented 4 years ago

Ever since I upgraded Atom to 1.47 for my Mac this package stopped working. When I save, a window pops open as normal, but it is blank.

When I tried on my older computer which was still on Atom 1.44 it worked no problem.

Screen Shot 2020-05-22 at 11 29 16 AM
pirple-author commented 4 years ago

+1, same issue here. Tried uninstalling and re-installing all MJML-related packages to no avail.

Atom 1.47.0 x64

iRyusa commented 4 years ago

Well after investigating, it looks like we can't change webview src like that anymore https://github.com/mjmlio/atom-mjml-preview/blob/master/lib/mjml-view.js#L82

n1ckc1n commented 4 years ago

I have the same issue on Windows 10.

iRyusa commented 4 years ago

As the problem is pretty much confirmed and identify no need to "+1" it :( cf https://github.com/mjmlio/atom-mjml-preview/issues/23#issuecomment-633307883

iRyusa commented 4 years ago

Seems like Webview is now working as expected on Atom 1.48 as https://github.com/atom/atom/pull/20855 fixed the issue

dirkdig commented 4 years ago

Yes