search

mjmlio / atom-mjml-preview

MJML preview in Atom
https://atom.io/packages/mjml-preview
MIT License
20 stars 4 forks source link

mj-wrapper doesn't appear #5

Closed Comicspidey closed 7 years ago

Comicspidey commented 7 years ago

Hello, When I use a mj-wrapper, preview is empty.

I try with this code https://mjml.io/try-it-live/components/wrapper

ngarnier commented 7 years ago

Hey @Comicspidey, thanks! Indeed the preview is running on v3.1.0. mj-wrapper was introduced in v3.3.0 which is still in beta, we'll update the plugin soon :-)

Comicspidey commented 7 years ago

@ngarnier thanks It would be interesting to mention the state "beta" in the official documentation ;-)

ngarnier commented 7 years ago

No worries! It's mentioned in the documentation and the release names :) https://github.com/mjmlio/mjml/releases

Comicspidey commented 7 years ago

Maybe I'm blind, but I don't see this mention : https://mjml.io/documentation/#mjml-wrapper ;-)

milolucero commented 7 years ago

Same here. I was using the documentation from the main link in the header of mjml.io, without realizing that it is for the beta and not for the stable release. That link should go to the stable release documentation, or else, avoid confusion by stating clearly which of those are beta features :)

ngarnier commented 7 years ago

Hey @Comicspidey & @MiloLucero, we chose to document v3.3.0 beta on the website as it's available on the try it live. Sorry it led to confusion, we'll be more careful regarding the mention of beta next time.

ngarnier commented 7 years ago

Fixed with v1.3.0, thanks