mjmlio / gulp-mjml

Add Gulp to your MJML workflow!
MIT License
161 stars 37 forks source link

Includes not working with relative paths #27

Closed cbrevik closed 6 years ago

cbrevik commented 6 years ago

As noted in https://github.com/mjmlio/gulp-mjml/issues/8#issuecomment-259505101 mj-include doesn't work with relative paths.

I see a PR where filePath is set on an object for includes, but I am not sure if it's used: https://github.com/mjmlio/gulp-mjml/pull/19/files#r130280996

Maybe the options sent into mjml2html should be localOptions instead?

Edit: I see there is an open PR for this #25

iRyusa commented 6 years ago

Hi @cbrevik

We've released the 2.3 version of gulp-mjml that should fix this