search

mjmlio / gulp-mjml

Add Gulp to your MJML workflow!
MIT License
162 stars 38 forks source link

Migrate to v4 #34

Closed mehrdad-shokri closed 6 years ago

mehrdad-shokri commented 6 years ago

Mjml is on v4.0.0 but this package is on v4.0.0.
Any plan to upgrade?

iRyusa commented 6 years ago

Both version are not dependent due to breaking changes, we're in process to upgrade every package in the ecosystem to MJML4 but this take some time. PR are also welcome

brianespinosa commented 6 years ago

Commenting here to express my interest in helping with this. If anyone decides to start work, let me know. I'll post here if I get a chance to start a branch and get working on this for anyone interested in helping.

jimblue commented 6 years ago

Hi there!

The PR to solve this issue is merged and seems to work great. Is it possible to publish a new release on NPM or there still something that need work?

Cheers

mehrdad-shokri commented 6 years ago

Apparently, a release to npm hasn't been published.

iRyusa commented 6 years ago

No need to post here + on the PR https://github.com/mjmlio/gulp-mjml/pull/35

We know that it's not released yet, we do our best to release every package in the ecosystem in MJML4 as fast as possible, thanks.

mattems commented 6 years ago

@mehrdaad if you want to use the latest put this in your package.json

"gulp-mjml": "git+https://git@github.com/mjmlio/gulp-mjml.git",

mehrdad-shokri commented 6 years ago

V3.0.0 release 12 hours ago!
Thanks, maintainers and all contributors.

mattems commented 6 years ago

@mehrdaad ?? where is this release?

mehrdad-shokri commented 6 years ago

@mattems https://www.npmjs.com/package/gulp-mjml?activeTab=versions