Closed eseliger closed 5 years ago
Hey together, I updated this pr to the latest master and this would still be nice to be merged, so this follows the gulp plugin guidelines!
Hi @eseliger Sorry about that one, can you just remove the package lock so we can merge it ? thanks !
Hey @iRyusa the package-lock has only been modified and not added, and only relfects the changes to the package.json in this pr :)
Yep I know but we want to use yarn across our projects :D
On 4 Jul 2018, at 20:53, Erik Seliger notifications@github.com wrote:
Hey @iRyusa the package-lock has only been modified and not added, and only relfects the changes to the package.json in this pr :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
So shall I remove it completely? 🤔
Yep please !
On 4 Jul 2018, at 21:14, Erik Seliger notifications@github.com wrote:
So shall I remove it completely? 🤔
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Done!
hey, @iRyusa any updates how we can push this forward?
Forgot to merge it sorry 👍
Thank you 🙂 let me know if you publish to npm!
I moved gulp to a
devDependency
, as per gulp plugin guideline. I also added the keywordgulpplugin
so it can be found in the gulp plugin search 🙂The mjml test file was also in mjml v3 format, I migrated it to v4 as it is the version which is allowed in the semver range
Closes #36