mjmlio / gulp-mjml

Add Gulp to your MJML workflow!
MIT License
162 stars 38 forks source link

NPM gulp-util deprecation warning #44

Closed jimblue closed 5 years ago

jimblue commented 5 years ago

Hi,

When running NPM install I get the following warning:

npm WARN deprecated gulp-util@3.0.8: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

So I've run npm ls gulp-util to get the list of plugins dependent on it, here is the result:

Screenshot 2019-06-22 at 16 17 36

But on my package.json I have only the following:

"devDependencies": {
    "gulp": "4.0.2",
    "gulp-mjml": "3.0.0",
    "mjml": "4.4.0-beta"
}

I guess it's because actual gulp-mjml 3 NPM release still use gulp3:

https://github.com/mjmlio/gulp-mjml/blob/9047d8d05f2df18a4f3e53fc6959bdf0ae1b0f15/package.json#L12

Whereas the actual master branch of gulp-mjml use gulp4:

https://github.com/mjmlio/gulp-mjml/blob/6093ee7f005c8c53286399d313ea2aac312f2a2b/package.json#L15

Can you release a new NPM version to fix that?

Thank you

jimblue commented 5 years ago

I've found others deprecations warnings also coming from gulp-mjml because of gulp-3 dependency:

npm WARN deprecated graceful-fs@1.2.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated graceful-fs@3.0.11: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js

Screenshot 2019-06-22 at 16 33 23

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Screenshot 2019-06-22 at 16 36 13

npm WARN deprecated natives@1.1.6: This module relies on Node.js's internals and will break at some point. Do not use it, and update to graceful-fs@4.x.

Screenshot 2019-06-22 at 16 36 53

jimblue commented 5 years ago

Just a friendly ping πŸ˜„ ! Could you please update gulp-mjml dependencies to solve this? Thank you

iRyusa commented 5 years ago

I've just published it today, and did upgrade through2 to the latest version too.

Let me know if there's anything broken, it seems to work fine with the example file.

jimblue commented 5 years ago

awesome! the new release fix it! thank you @iRyusa πŸŽ‰

iRyusa commented 5 years ago

It looks like there’s an issue and we have to release a 4.0.1 asap cf #46 :(

My bad.

On 2 Jul 2019, at 19:09, Jim Blue notifications@github.com wrote:

awesome! the new release fix it! thank you @iRyusa πŸŽ‰

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kmcb777 commented 5 years ago

@jimblue The fix is released, it's actually 4.0.2 (my bad)

jimblue commented 5 years ago

I made the upgrade directly to latest before trying! So I didn't found any bug while testing it... But anyway thanks to ping me @kmcb777 !