search

mjmlio / gulp-mjml

Add Gulp to your MJML workflow!
MIT License
162 stars 38 forks source link

Unable to set fileExt #53

Closed macmichael01 closed 4 years ago

macmichael01 commented 4 years ago

I am trying to set fileExt to .email but the files are still getting output as .html After digging through the code, I found that this line is reflecting a different value. Instead, what I am seeing is: output.path = replaceExt(file.path.toString(), ".html");

Has the npm package been updated to reflect the latest changes?

pabueco commented 4 years ago

Same problem here. I temporarely fixed it by using gulp-rename:

.pipe(rename(path => {
    path.extname = '.extension';
}))
macmichael01 commented 4 years ago

npm is not in sync with what is on github. Please bump npm version.

iRyusa commented 4 years ago

I'll see if I can do it this week

Zaszczyk commented 4 years ago

I'll see if I can do it this week

Have you tried to fix it? I have same problem.

iRyusa commented 4 years ago

I think this has been shipped for a while now ? 3.0.1 has it

Zaszczyk commented 4 years ago

I think this has been shipped for a while now ? 3.0.1 has it

Right, but it does not work. Process finish successfully, but files keep old extension.

iRyusa commented 4 years ago

Can you share maybe your current gulp file ?

Edit : it seems like current npm version doesn't have the fileExt options I will update it asap