search

mjmlio / mjml

MJML: the only framework that makes responsive-email easy
https://mjml.io
MIT License
17.08k stars 960 forks source link

mj-social doesn't always work in windows app #1114

Closed ChrisPlaneta closed 6 years ago

ChrisPlaneta commented 6 years ago

The problem occurs when I use mj-social with an attribute display="facebook:url" in an included file. Changing to display="facebook" solves things but then the generated link is a share link rather than an ordinary link.

Reproduction Steps:

  1. Create 2 tempalte parts - main and header
  2. include "header" in "main"
  3. insert mj-social tag in header part - use display="facebook:url"

Expected behavior:

A facebook icon with a proper link should appear

Observed behavior:

Nothing appeares

Screenshots and GIFs

MJML version:

MJML App 2.8.0

iRyusa commented 6 years ago

Hi,

mj-social has a new markup in MJML4 that you can check here : https://github.com/mjmlio/mjml/tree/master/packages/mjml-social

On Tue, Apr 3, 2018 at 3:41 PM, Chris Planeta notifications@github.com wrote:

The problem occurs when I use mj-social with an attribute display="facebook:url" in an included file. Changing to display="facebook" solves things but then the generated link is a share link rather than an ordinary link.

Reproduction Steps:

  1. Create 2 tempalte parts - main and header
  2. include "header" in "main"
  3. insert mj-social tag in header part - use display="facebook:url"

Expected behavior:

A facebook icon with a proper link should appear

Observed behavior:

Nothing appeares

Screenshots and GIFs

MJML version:

MJML App 2.8.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mjmlio/mjml/issues/1114, or mute the thread https://github.com/notifications/unsubscribe-auth/AAizzfix5BOQyCrVhePse7oYpbjtiSylks5tk3v5gaJpZM4TFGL1 .

-- Cordialement, Maxime BRAZEILLES

ChrisPlaneta commented 6 years ago

I didn't know about that. But I've checked it right now in your online editor and I cannot hide unnecessary icons and their texts. Here's the url > https://mjml.io/try-it-live/Sy1I3b-sM

What am I doing wrong?

iRyusa commented 6 years ago

Website is still on MJML3 branch, that's why

On Tue, Apr 3, 2018 at 4:17 PM, Chris Planeta notifications@github.com wrote:

I didn't know about that. But I've checked it right now in your online editor and I cannot hide unnecessary icons and their texts. Here's the url

https://mjml.io/try-it-live/Sy1I3b-sM

What am I doing wrong?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mjmlio/mjml/issues/1114#issuecomment-378265974, or mute the thread https://github.com/notifications/unsubscribe-auth/AAizzbQ5YhX2tMtJZ1bcT6oTaVvCvA3Xks5tk4STgaJpZM4TFGL1 .

-- Cordialement, Maxime BRAZEILLES

ChrisPlaneta commented 6 years ago

I see. OK. Thank you!