mjmlio / mjml

MJML: the only framework that makes responsive-email easy
https://mjml.io
MIT License
17.03k stars 957 forks source link

[Documentation] Change the colours of the code section #1696

Open kud opened 5 years ago

kud commented 5 years ago

The code on the documention is tough to read. Maybe it's because I'm a bit colourblind but it hurts my eyes to read the code.

image

Some tools:

https://codemirror.net/demo/theme.html#material could be nice.

Thank you!

kud commented 5 years ago

Code's here: https://github.com/mjmlio/slate/tree/master/source/stylesheets

dougfabris commented 5 years ago

Hey @kud I agree with you, the code colors of documentation hurts our eyes. So I tried this combination without make a big change in actual color palette. First of all, I believe we need to change background-color and his shadows and then, change the red color to another that make more contrast and less brightness. Do you think it could be better like that?

code contrast contrast-ratio

kud commented 5 years ago

That's really great! Thank you to answer so quickly too!

I'm more than ok with those colours! Good for me.

dougfabris commented 5 years ago

@kud You're very welcome! The MJML project helps me a lot... I'm always trying to do the same, as I can.

iRyusa commented 5 years ago

cc @ngarnier

iRyusa commented 4 years ago

@kud @dougfabris

Is current try it live (https://mjml.io/try-it-live) theme accessible enough ? So we can maybe use this one instead ? Or we should update it to so we can re-use the same on both doc & try it live ?

kud commented 4 years ago

Yes, it's ok for me, with maybe a darker background.

dougfabris commented 4 years ago

@iRyusa I agree with @kud. To be more accessible, maybe we will have to use a darker background, to get a nice contrast with the red color. This tool is a good option to check the contrast ratio: https://contrast-ratio.com/