mj-location always displaying the default image

[DHDaniel]

The mj-location component, which allows you to set an address which will link to Google Maps, provides a default photo to accompany it. The component has an attribute, src, which also allows you to display your own photo.

However, changing the src attribute to something else will always end up displaying the default image - it is necessary to go into the compiled HTML file and change it from there in order to add your own custom image.

How to reproduce error:

• Use an component and add a custom src attribute.
• Compile to MJML and view the result.

It should display your custom image, but it displays the default.

Here, you can see the issue on the online MJML editor using the latest version of Google Chrome.

Atom version : 1.8.0 Language MJML version : 1.3.0

[Everus]

It's typo in the documentation, you should use img-src attribute.

[DHDaniel]

Thanks for the clarification, @Everus

[ngarnier]

Thanks for submitting this issue @DHDaniel and thank you @Everus for solving it! We'll update the documentation.

By the way, have you seen that the v2 (now 2.2.0) was released? A lot of new features that you will likely enjoy were added :-)

[DHDaniel]

Using MJML again, looked at documentation, and apparently it still says "src" instead of "img-src" on the website (https://mjml.io/documentation/#mjml-location). However, it does appear correctly in https://github.com/mjmlio/mjml/tree/master/packages/mjml-location . Could it be added to the website as well, to avoid confusion?

[ngarnier]

Hey @DHDaniel, thanks for your message. It'll be updated on the website when we release MJML v2.3.0, very likely next week :-).

[iRyusa]

Website will be updated tomorrow, and it has been fixed in the github documentation

[ashishtilara]

is Mj-location supported in v4+?

I am seeing following while using mj-location, any idea Line undefined of undefined (mj-location) — Element mj-location doesn't exist or is not registered

MJML v4.0.5.

Appreciate any help :)

[iRyusa]

Hi,

mj-location has been removed in MJML4

On Tue, May 1, 2018 at 1:10 PM Ashish Tilara notifications@github.com wrote:

is Mj-location supported in v4+?

I am seeing following while using mj-location, any idea Line undefined of undefined (mj-location) — Element mj-location doesn't exist or is not registered

MJML v4.0.5.

Appreciate any help :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mjmlio/mjml/issues/308#issuecomment-385648327, or mute the thread https://github.com/notifications/unsubscribe-auth/AAizzfczanW82xCKn8KtBjh3VbYm6aBSks5tuEK-gaJpZM4I5LiP .

-- Cordialement, Maxime BRAZEILLES

[epsilon-senzio]

sad to hear this. it is still listed on your website though > maybe remove it there, too.

https://mjml.io/components

[ngarnier]

As it's very easy to reproduce with a simple mj-image and mj-text, the added value is very weak, which is why we removed it.

@jakob-senzio the components page is not accessible from the navigation anymore, how did you find it, Google?

[epsilon-senzio]

yup, found it via google.