Closed jfcere closed 8 months ago
The mj-html-attributes, mj-selector and mj-html-attribute elements added in MJML 4.7.0 should be recognized by the VsCode extension.
mj-html-attributes
mj-selector
mj-html-attribute
Currently, all the elements mentioned above are not recognized as a valid element by the VsCode extension.
Try adding the code provided in the code section below in a MJML file with the VsCode extension.
Official documentation reference: https://documentation.mjml.io/#mj-html-attributes
<mjml> <mj-head> <mj-html-attributes> <mj-selector path=".custom div"> <mj-html-attribute name="data-id">42</mj-html-attribute> </mj-selector> </mj-html-attributes> </mj-head> <mj-body> <mj-section> <mj-column> <mj-text css-class="custom"> Hello World! </mj-text> </mj-column> </mj-section> </mj-body> </mjml>
Please attach screenshot/gif if you consider them as helpful to understand/reproduce the issue.
There is already a PR to fix this by updating MJML to 4.7.0: https://github.com/mjmlio/vscode-mjml/pull/8
The related PR has been closed since the extension has been updated to support MJML 4.10 therefore I am closing this old issue.
Expected behavior
The
mj-html-attributes
,mj-selector
andmj-html-attribute
elements added in MJML 4.7.0 should be recognized by the VsCode extension.Actual behavior
Currently, all the elements mentioned above are not recognized as a valid element by the VsCode extension.
Steps to reproduce the problem
Try adding the code provided in the code section below in a MJML file with the VsCode extension.
Code sample
Screenshot / GIF
Please attach screenshot/gif if you consider them as helpful to understand/reproduce the issue.
Specifications
Other information
There is already a PR to fix this by updating MJML to 4.7.0: https://github.com/mjmlio/vscode-mjml/pull/8