search

mjohnston / react-native-webpack-server

Build React Native apps with Webpack
MIT License
933 stars 84 forks source link

bundle: be more resilient against timeouts #144

Closed philikon closed 8 years ago

philikon commented 8 years ago

Also don't attempt to fetch the bundle until the RN packager server is actually up. There's little point in trying sooner.

ghost commented 8 years ago

CI build failed for this change failed. Ironically due to a timeout.

philikon commented 8 years ago

Ironically due to a timeout.

Yeah, that is pretty funny. I wonder if the Promise.all() change is responsible for that somehow...

philikon commented 8 years ago

Being cautiously optimistic here, but these changes seem to have fixed a slew of long-standing issues with the super slow Travis CI machines. It'd be great to get them merged and released.

@elliottsj @mjohnston, I know you guys aren't using this actively, but would either of you be willing to review this code here and spin a release? Alternatively, I'll be happy to take care of it too (minus the review part of course) if you guys want to grant me push/release privileges.

mjohnston commented 8 years ago

Change looks good to me. I'll get you set up with push/release access.

philikon commented 8 years ago

Thanks @mjohnston!

mjohnston commented 8 years ago

No problem - you should also be able to publish the npm package now.

philikon commented 8 years ago

Sweet! I'll release 0.8.2 soon.