search

mjordan / islandora_onthisday

Utility module that generate a gallery of objects with a month and day equal to the current day's
GNU General Public License v3.0
1 stars 2 forks source link

Ignore Newspaper Page objects #13

Closed bondjimbond closed 7 years ago

bondjimbond commented 7 years ago

If you have a newspaper issue with multiple pages on a given day, onthisday will list each page from that issue (i.e. June 30, 1923 page 1, June 30, 1923 page 2, etc.)... Should just display the Issue, not the individual page.

Don't know whether this happens with Books.

mjordan commented 7 years ago

We already have a "Collections to exclude" admin setting. What if we added a "Content models to exclude" setting, where we could specify newspaper and book pages?

bondjimbond commented 7 years ago

That would be perfect.

bondjimbond commented 7 years ago

Bumping this. I was thinking of doing some work on the issue basing it off your "collections to exclude" setting, but I don't actually see that setting in the module. Is that on an unmerged commit?

mjordan commented 7 years ago

Nope, the admin setting for it is at https://github.com/mjordan/islandora_onthisday/blob/7.x/islandora_onthisday.module#L85.

bondjimbond commented 7 years ago

Aaaah, didn't realize it was hidden by the checkbox. Thanks.

I'll see if I can do anything with this when I have a minute.

mjordan commented 7 years ago

@bondjimbond great, thank you.

mjordan commented 7 years ago

Closed with bf2c9b0fc21108de141115d607fa756ebef56dba.