search

mjordan / persistent_identifiers

Drupal 8/9 Module that provides a generalized framework for minting and persisting persistent identifiers (DOIs, ARKs, etc.).
GNU General Public License v2.0
5 stars 11 forks source link

1) separate DOI draft and finalization 2) mint Handle pid correctly #30

Closed mzhuangsdsc closed 1 year ago

mzhuangsdsc commented 1 year ago

Hello! I made some changes to Persistent Identifiers module in order to get it fully work on my drupal site. Two major changes in my commit: 1) separate DOI draft and finalization 2) mint Handle pid correctly. Thanks.

mjordan commented 1 year ago

@mzhuangsdsc thank you for your work. I am no longer maintaining this module. I have explained my decision to my friends in the Islandora community a while ago but never got around to mirroring that information in the module's README.

However, I do say in the README that I would like people who want to contribute to open an issue so we can discuss their contribution prior to opening a PR.

I will merge your PR (thanks again for the work) but I do not have time to test it.

mzhuangsdsc commented 1 year ago

Thank you very much! Sorry I didn’t open an issue first.

Mark Zhuang

On Apr 12, 2023, at 6:57 AM, Mark Jordan @.**@.>> wrote:

@mzhuangsdschttps://urldefense.com/v3/__https://github.com/mzhuangsdsc__;!!Mih3wA!EdsUjx8tt1N7x1lZrsFpaWJw8ArOWN55kIOAimeDhDVmRrvlalRhk8EG25fqweWIdZja0cseG2Av5_QDHql8Ap6f$ thank you for your work. I am no longer maintaining this module. I have explained my decisionhttps://urldefense.com/v3/__https://groups.google.com/g/islandora/c/ZH0ypoyVmdQ/m/Dgr_3xJfAQAJ__;!!Mih3wA!EdsUjx8tt1N7x1lZrsFpaWJw8ArOWN55kIOAimeDhDVmRrvlalRhk8EG25fqweWIdZja0cseG2Av5_QDHuSo8Mpx$ to my friends in the Islandora community a while ago but never got around to mirroring that information in the module's README.

However, I do say in the README that I would like people who want to contribute to open an issue so we can discuss their contribution prior to opening a PR.

I will merge your PR (thanks again for the work) but I do not have time to test it.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/mjordan/persistent_identifiers/pull/30*issuecomment-1505325015__;Iw!!Mih3wA!EdsUjx8tt1N7x1lZrsFpaWJw8ArOWN55kIOAimeDhDVmRrvlalRhk8EG25fqweWIdZja0cseG2Av5_QDHsxp5pdi$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/APONAXGKROJP6MUL7XE2S5DXA2YDJANCNFSM6AAAAAAWYXNISU__;!!Mih3wA!EdsUjx8tt1N7x1lZrsFpaWJw8ArOWN55kIOAimeDhDVmRrvlalRhk8EG25fqweWIdZja0cseG2Av5_QDHgH8pwTf$. You are receiving this because you were mentioned.Message ID: @.***>