mjpearson / passport-slack

Slack OAuth2 strategy for Passport
MIT License
104 stars 69 forks source link

Slack would like to help contribute and maintain this package #38

Open aoberoi opened 6 years ago

aoberoi commented 6 years ago

Hi @mjpearson, I saw the note in your README about how you could use some help and I'd like to discuss what you have in mind. Thanks for carrying this package forward for as long as you have. It's clear that you put a lot of care and work into it.

My name is Ankur and I work on developer tools at Slack. Our team builds and maintains packages and tools in collaboration with the community. OAuth plays a pretty critical role in how developers deal with user identity in their app (Sign in with Slack) and handle installation (Add to Slack) - and we think this package is important to how developers implement these features.

I've got a little bit of experience working with passport, OAuth, and Slack's APIs. I maintain another implementation of a Slack passport strategy. I'd be excited to help, in almost any way that you are open to. There's also an opportunity to deliver the next generation of this package in a way that supports workspace apps as a first class citizen.

Here's what my vision looks like: I'd like to triage the current open issues and pull requests so we make sure we know what users of this package need. Next, we create a plan to merge my implementation with this one. Maybe we write some tests. Finally, if you're comfortable with it, we can take lead by moving this repo over to the slackapi github organization and we could gain publish access to the passport-slack package on npm.

If you want to chat outside of this issue, feel free to email me: ankur@slack-corp.com

mjpearson commented 6 years ago

Do you have a slack.com email I can reach you at?

On Mon, Sep 10, 2018, 7:04 PM Ankur Oberoi notifications@github.com wrote:

Hi @mjpearson https://github.com/mjpearson, I saw the note in your README about how you could use some help and I'd like to discuss what you have in mind. Thanks for carrying this package forward for as long as you have. It's clear that you put a lot of care and work into it.

My name is Ankur and I work on developer tools at Slack. Our team builds and maintains packages and tools in collaboration with the community. OAuth plays a pretty critical role in how developers deal with user identity in their app (Sign in with Slack) and handle installation (Add to Slack) - and we think this package is important to how developers implement these features.

I've got a little bit of experience working with passport, OAuth, and Slack's APIs. I maintain another implementation of a Slack passport strategy https://github.com/aoberoi/passport-slack. I'd be excited to help, in almost any way that you are open to. There's also an opportunity to deliver the next generation of this package in a way that supports workspace apps https://api.slack.com/workspace-apps-preview as a first class citizen.

Here's what my vision looks like: I'd like to triage the current open issues and pull requests so we make sure we know what users of this package need. Next, we create a plan to merge my implementation with this one. Maybe we write some tests. Finally, if you're comfortable with it, we can take lead by moving this repo over to the slackapi github organization and we could gain publish access to the passport-slack package on npm.

If you want to chat outside of this issue, feel free to email me: ankur@slack-corp.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjpearson/passport-slack/issues/38, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg2Ioz1MvuQSlWV3HkcVAehQ8U3dDvks5uZu_qgaJpZM4WiUbw .

aoberoi commented 6 years ago

@mjpearson my work email is ankur@slack-corp.com. we don't use slack.com for employee email addresses (origin separation). if you'd like to verify who i am, feel free to take a look at my github profile and org memberships: github.com/aoberoi.

mjpearson commented 6 years ago

Hi Ankur, sorry for the delay, i'll get to this soon. Which owner on NPM should I transfer it to, is that @slackapi also or @slack?

regards mike p

On Mon, Sep 10, 2018 at 7:22 PM Ankur Oberoi notifications@github.com wrote:

@mjpearson https://github.com/mjpearson my work email is ankur@slack-corp.com. we don't use slack.com for employee email addresses (origin separation). if you'd like to verify who i am, feel free to take a look at my github profile and org memberships: github.com/aoberoi.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjpearson/passport-slack/issues/38#issuecomment-420093246, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg2AYv56CMVVpR2EJAJPvbsYlEuMPrks5uZvRGgaJpZM4WiUbw .

-- http://www.linkedin.com/in/mjpearson +1 415 409 8137

aoberoi commented 6 years ago

For NPM: I don’t think we should transfer the package to anyone, just add myself as an owner on the package (my npm username is aoberoi). This way existing users of this package will not break. I’m happy to keep you on, but if you prefer to be removed, that’s fine with me!

For GitHub: we could transfer this repo to the @slackapi org. Before we do this, I’d like to make several updates so that the status of the project is clear. For now, you can add me as a collaborator on the repo and when everything is ready I can transfer it to the org.

mjpearson commented 6 years ago

Ok thanks, I'll get to it tomorrow.

On Thu, Sep 13, 2018, 4:45 PM Ankur Oberoi notifications@github.com wrote:

For NPM: I don’t think we should transfer the package to anyone, just add myself as an owner on the package (my npm username is aoberoi). This way existing users of this package will not break. I’m happy to keep you on, but if you prefer to be removed, that’s fine with me!

For GitHub: we could transfer this repo to the @slackapi https://github.com/slackapi org. Before we do this, I’d like to make several updates so that the status of the project is clear. For now, you can add me as a collaborator on the repo and when everything is ready I can transfer it to the org.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjpearson/passport-slack/issues/38#issuecomment-421147304, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg2I-hmDCTcSE4ZRRXyk7ZDHsaqwhKks5uasQCgaJpZM4WiUbw .

mjpearson commented 6 years ago

Hi, I added you to the repo. Will look out for PR's, let me know when it's good to be delagated in npm

-mike

On Thu, Sep 13, 2018, 6:42 PM Michael Pearson mjpearson@gmail.com wrote:

Ok thanks, I'll get to it tomorrow.

On Thu, Sep 13, 2018, 4:45 PM Ankur Oberoi notifications@github.com wrote:

For NPM: I don’t think we should transfer the package to anyone, just add myself as an owner on the package (my npm username is aoberoi). This way existing users of this package will not break. I’m happy to keep you on, but if you prefer to be removed, that’s fine with me!

For GitHub: we could transfer this repo to the @slackapi https://github.com/slackapi org. Before we do this, I’d like to make several updates so that the status of the project is clear. For now, you can add me as a collaborator on the repo and when everything is ready I can transfer it to the org.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjpearson/passport-slack/issues/38#issuecomment-421147304, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg2I-hmDCTcSE4ZRRXyk7ZDHsaqwhKks5uasQCgaJpZM4WiUbw .

aoberoi commented 6 years ago

You can add me as an owner now. This command line command should do it. npm owner add aoberoi passport-slack.

I can land the PRs over the next couple days, and when everything is all set I’ll need your help once more to move the repo on GitHub under the @slackapi Org.

Thanks!

mjpearson commented 6 years ago

No worries, thanks I added you as owner.

I know its only a few lines of code but thanks for showing it love and finding it a proper home.

-mike

On Mon, Sep 17, 2018 at 1:24 AM Ankur Oberoi notifications@github.com wrote:

You can add me as an owner now. This command line command should do it. npm owner add aoberoi passport-slack.

I can land the PRs over the next couple days, and when everything is all set I’ll need your help once more to move the repo on GutHub under the @slackapi https://github.com/slackapi Org.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjpearson/passport-slack/issues/38#issuecomment-421892744, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg2FkdaCv5Fnoc692qlcgvNdaxgQ2Mks5ubzIEgaJpZM4WiUbw .

-- http://www.linkedin.com/in/mjpearson +1 415 409 8137