search

mjphaynes / php-resque

php-resque is a Redis-backed PHP library for creating background jobs, placing them on multiple queues, and processing them later.
MIT License
222 stars 50 forks source link

Fix deprecation warnings on PHP 8.1 #103

Closed MiRacLe-RPZ closed 1 year ago

MiRacLe-RPZ commented 1 year ago

strftime -> date strlen($null) -> !empty($null) dechex($float) -> dechex((int)$float) remove is_callable(['classname', 'method'])

Also some minor fixes and bump staled Resque::VERSION

linkuha commented 1 year ago

thanks! I ran into a problem today in the prod when upgrading to 8.2. the commit 7047123 is not only about warnings. due to new case https://www.php.net/manual/en/function.is-callable.php#126199 - now it causes error in my jobs. I need the author to accept this PR

temporary solution is replacing to your fork in composer.json is helped me: "require": { "mjphaynes/php-resque": "php81compat-dev" }, "repositories": [ { "type": "vcs", "url": "https://github.com/MiRacLe-RPZ/php-resque.git" } ],

xelan commented 1 year ago

Thanks for your PR @MiRacLe-RPZ and for the comment @linkuha! I'll review and test the changes :+1:

xelan commented 1 year ago

Just a few minor comments, could you please have a look @MiRacLe-RPZ?

MiRacLe-RPZ commented 1 year ago

Hi, where can i see your comments?

xelan commented 1 year ago

Hi, where can i see your comments?

Hi, in the "Files changed" overview (or here above in the review comments). Thank you!

MiRacLe-RPZ commented 1 year ago

nope, maybe you must Request Changes for publish comments?

xelan commented 1 year ago

Aaah, I'm normally working on Gitlab... done thank you :+1:

MiRacLe-RPZ commented 1 year ago

Just a few minor comments

@xelan, done

xelan commented 1 year ago

Thank you very much, @MiRacLe-RPZ