search

mjphaynes / php-resque

php-resque is a Redis-backed PHP library for creating background jobs, placing them on multiple queues, and processing them later.
MIT License
221 stars 50 forks source link

Symfony v4 beta #71

Closed MaximeMaillet closed 1 year ago

MaximeMaillet commented 6 years ago

70

xelan commented 6 years ago

Hi @MaximeMaillet! Thank you for your PR!

Your current approach would prohibit the usage of Symfony 3, it should be ~2.7|~3.0|~4.0.0 instead. Or even better, just ~2.7|~3.0|~4.0 to allow 2.7 and higher Symfony 2 versions, 3.0 and higher Symfony 3 versions, and 4.0 and higher Symfony 4 versions.

By the way, did you check that all used method calls/classes/... are compatible between Symfony 2, 3 and 4?

merlindorin commented 6 years ago

@xelan from my point of view, trying to get a compatibility across Symfony's versions is hazardous without a bench of test. The main reason is not the initial work (which is quite intensive), it's mainly for the code maintainability.

Any simple piece of code have to be review across version. This point will limit any enhancements and new features.

Maybe we can add as requirement the write of test for any new feature/enhancement. I can write a .travis.yml if you need a starting point.

Just a point of view ;).

xelan commented 6 years ago

Right, that's why the last PR integrating support for Symfony 3.x took quite some time and also manual testing effort. Having a comprehensive test suite would defintely help a lot! See #26 for the discussion about that.

Thank you very much for your offer to help with creating a test suite. In my opinion, it would be best to start with a test suite now even before the changes for 4.x to detect and mitigate possible compatiblity issues.

merlindorin commented 6 years ago

blocked by #72 ;) (I will finished my PR tomorrow ;) )

merlindorin commented 6 years ago

Following #78, if people are agreed, I think we can delete this PR or move it to a new repo like php-resque-cli

xelan commented 4 years ago

@mjphaynes What do you think about the separation of the php-resque core from the CLI? Now that Symfony 4 is entering LTS soon and 5 to be released shortly, this becomes more important IMHO.

xelan commented 3 years ago

Any news @mjphaynes? As Symfony 5 is gaining traction, proper support seems to become more important for this project as well. By the way, maybe we should also re-evaluate the minimum requirements (e.g. go to PHP 7.1+?)

xelan commented 1 year ago

Implemented in php-resque v3 :+1: :partying_face: