mjpost / bibsearch

Download, manage, and search a BibTeX database.
Other
63 stars 5 forks source link

Open from search #33

Closed cl3wis closed 6 years ago

cl3wis commented 6 years ago

I tried using bibsearch open to open the result of a query, and got this traceback:

$ bibsearch open "deep contextualized"
Traceback (most recent call last):
  File "/home/chris/.pyenv/versions/3.6.4/bin/bibsearch", line 11, in <module>
    load_entry_point('bibsearch==0.3.9', 'console_scripts', 'bibsearch')()
  File "/home/chris/.pyenv/versions/3.6.4/lib/python3.6/site-packages/bibsearch/bibsearch.py", line 701, in main
    args.func(args, config)
  File "/home/chris/.pyenv/versions/3.6.4/lib/python3.6/site-packages/bibsearch/bibsearch.py", line 223, in _open
    bibtex, key = _get_cache_or_search_result(db, args.terms)
  File "/home/chris/.pyenv/versions/3.6.4/lib/python3.6/site-packages/bibsearch/bibsearch.py", line 198, in _get_cache_or_search_result
    results = db.search(args.terms)
NameError: name 'args' is not defined
mjpost commented 6 years ago

Thanks for the PR! Before looking into this, do you mind

If the problem still persists, could you rebase on current master? I can then take a look later tonight.

matt

mjpost commented 6 years ago

Actually, it's clear the problem exists even from the code. If you could rebase, though, I could pull it in.

cl3wis commented 6 years ago

Sure thing! I'm not too familiar with github forks compared to regular git branches, but I think I've done the rebase successfully.

mjpost commented 6 years ago

Thanks again!