mjpost / sacrebleu

Reference BLEU implementation that auto-downloads test sets and reports a version string to facilitate cross-lab comparisons
Apache License 2.0
1.03k stars 162 forks source link

GitHub workflows CI tests fail on Python 3.6 #233

Closed martinpopel closed 1 year ago

martinpopel commented 1 year ago

I've tried to solve it in #232, with no success. So I give up. If someone knows how to fix it, please help us. Otherwise, I will drop support for Python 3.6 (both for the tests and python_requires='>=3.6', in setup.py, as it does not make sense to support a Python version which is not covered by CI).

ales-t commented 1 year ago

Investigating this a bit further, it seems that ubuntu-latest is now 22.04 and Python 3.6 is not supported there in GitHub actions: https://github.com/actions/setup-python/issues/544

See also this versions manifest: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

One possibility would be to do the following changes:

WDYT? I'd be happy to create a PR for that.

ales-t commented 1 year ago

I had to update a bunch of dependencies quite carefully and now it seems like CI should work. However, I get (randomly, AFAICT) internal errors for some jobs when the actions run: https://github.com/mjpost/sacrebleu/actions/runs/4938094678

Github reports no outstanding warnings or issues though, so maybe simply re-running the CI pipeline in a few hours could be worth a try? (I don't have permissions to do that it seems.)