Closed jkawamoto closed 2 months ago
@mjpost @ozancaglayan Do you agree with dropping support for Python 3.6 and 3.7 (which are end of life)? I agree because I don't see any other easy way how to prevent CI failures in future (and we cannot officially support Python versions which we don't test with CI).
Hi. There's no reason to keep 3.6 and 3.7 there I agree. 3.8 is also coming to EOL October 2024. We could drop that one later as well.
Thanks for the PR!
It would be good to do a v2.4 release probably once merged.
Thanks, guys—I agree about dropping support. 2.4.2 was released a while ago; I don't think we need a new release with this PR?
I was looking at https://github.com/mjpost/sacrebleu/releases which shows 2.3.x as the latest.
Ah, yeah, I should update that. It's a separate process. 2.4.2 is available on pypi.
Actually I'm sure there's a way to do this:
I dont have time currently but yes there is:
run:
step
This PR addresses recent CI errors. It includes the following changes:
mecab-python3
to support Apple Silicon and Python 3.12.mecab-ko
on Apple Silicon or Python 3.12 because it doesn’t support them yet. (https://github.com/NoUnique/pymecab-ko/issues/2, https://github.com/NoUnique/pymecab-ko/issues/8)