search

mjpost / sacrebleu

Reference BLEU implementation that auto-downloads test sets and reports a version string to facilitate cross-lab comparisons
Apache License 2.0
1.03k stars 162 forks source link

Fix CI Errors #266

Closed jkawamoto closed 2 months ago

jkawamoto commented 2 months ago

This PR addresses recent CI errors. It includes the following changes:

martinpopel commented 2 months ago

@mjpost @ozancaglayan Do you agree with dropping support for Python 3.6 and 3.7 (which are end of life)? I agree because I don't see any other easy way how to prevent CI failures in future (and we cannot officially support Python versions which we don't test with CI).

ozancaglayan commented 2 months ago

Hi. There's no reason to keep 3.6 and 3.7 there I agree. 3.8 is also coming to EOL October 2024. We could drop that one later as well.

Thanks for the PR!

ozancaglayan commented 2 months ago

It would be good to do a v2.4 release probably once merged.

mjpost commented 2 months ago

Thanks, guys—I agree about dropping support. 2.4.2 was released a while ago; I don't think we need a new release with this PR?

ozancaglayan commented 2 months ago

I was looking at https://github.com/mjpost/sacrebleu/releases which shows 2.3.x as the latest.

mjpost commented 2 months ago

Ah, yeah, I should update that. It's a separate process. 2.4.2 is available on pypi.

mjpost commented 2 months ago

Actually I'm sure there's a way to do this:

ozancaglayan commented 2 months ago

I dont have time currently but yes there is: