search

mjrgh / PinballY

A table browser and launcher ("front end") for virtual pinball cabinets.
Other
47 stars 22 forks source link

Audio Not playing during table browsing #116

Closed starwyvern closed 4 years ago

starwyvern commented 4 years ago

mjr,

Here is the audio file that isn't playing during table selection. Audio File.zip

mjrgh commented 4 years ago

Thanks for the test case. It looks like DirectShow (the Microsoft subsystem that we're using right now to play back MP3 files) is just too old for the encoding format used in this file. I'm going to move the MP3 playback over to libvlc instead, since it's more modern and is being actively developed and supported (unlike DShow). I confirmed that this file plays back fine with libvlc, so moving to the new codecs should fix this and any other MP3's that haven't been playing back under DShow. (And it's better to use libvlc anyway, since we're already incorporating it for video playback; so this change will have the nice side effect of eliminating an external dependency, and one that Microsoft considers obsolete at that.)

starwyvern commented 4 years ago

Thanks for looking into it! Will that be an update to Pinball Y? Other MP3s I put in the table audio get the same error as well.

mjrgh commented 4 years ago

Yes, it'll be in the next update.

mjrgh commented 4 years ago

The Beta 21 has the new libvlc playback - that should fix it.