search

mjrgh / PinballY

A table browser and launcher ("front end") for virtual pinball cabinets.
Other
47 stars 22 forks source link

Custom media rotation #206

Open timhobbs opened 2 years ago

timhobbs commented 2 years ago

Describe the bug Custom media rotation does not work for videos

NOTE: it is not completely clear whether or not video rotation should work. The doc for custom media does mention image rotation, but there is also a mention that table videos are rotated. Based on how rotation does not work for custom media videos I assume that it is not intended to work with videos, but there is mention of how other systems expect rotated video media so I do think that rotation should be applied. Using existing table loading animations (from VPU) requires either PBY to support rotation or for the user to rotate all the loading animations (which is kind of a PITA, even with a batch file to do the heavy lifting).

To Reproduce

  1. Create custom media just like the example in the repo, but set a rotation value
  2. Load a table that will load the custom table loading animation

Expected behavior The table video should be oriented correctly

Screenshots

VIDEO Capture

PBY Capture2

I realize the video is technically not the correct orientation per the docs (with bottom of table to left) but this is the way the loading animations are oriented from VPU so I assume this must be the way some other system expects them? (PBX? Popper?) Regardless, if rotation is enabled you could set it at 180 and the media would display correctly.

Windows version Windows 10

Additional context Add any other context about the problem here.

timhobbs commented 2 years ago

from the gameex forum:

Do note loading video's in pinballx are not rotated so you have to create them as how you would see them normally without rotation so below's video is good if you run in landscape mode (270° rotation) they don't have to be in same rotation as playfield videos

it would appear that since most run their tables at 270 that is why they are all not necessarily oriented correctly with the bottom to the left. however, i do still feel that the rotation should work and would allow the use of available loading animations without having to modify them. ffmpeg can do it (that is what i an using to rotate them now) but i can understand if there are concerns over performance.