search

mjrgh / PinballY

A table browser and launcher ("front end") for virtual pinball cabinets.
Other
47 stars 22 forks source link

Screenshots flipped upside-down when using ddagrab in 1.1 Beta 10 #252

Open jueank opened 4 days ago

jueank commented 4 days ago

I just tested ddagrab in version 1.1 Beta 10, using the suggested image codec options: -frames:v 1 -update 1 I use exclusive fullscreen mode for VPX. Fullscreen optimisations are disabled (see here: https://devblogs.microsoft.com/directx/demystifying-full-screen-optimizations/)

The captured playfield was flipped upside down. Is this to be expected because you let users control the ffmpeg options for ddagrab completely on their own (meaning they have to add a video transform parameter), or should this treated as a bug?

mjrgh commented 4 days ago

Did you include the [videoTransforms] in the source options per the help?

http://mjrnet.org/pinscape/downloads/PinballY/Help/CaptureFfmpegOptions.html#ddagrab-how-to

jueank commented 4 days ago

It's working now as intended with the entries from the help in 'Video Source Options'. Now that you mention it, it's obvious, but to be honest - I thought 'video source options' are really only relevant for video encoding, not for single images. But technically, it makes sense and I should have known if I had thought about it for 3 seconds longer... You could change the name to 'Video & Image Source Options' if you want to?

mjrgh commented 4 days ago

You could change the name to 'Video & Image Source Options' if you want to?

Good idea - I agree it's a little misleading that it only mentions video.

jueank commented 3 days ago

I would like to say thank you for including the ddagrab option! I have used it quite a lot in the last 2 days already. It works very reliably! Much better than gdigrab where I had to ALT-TAB out and ALT-TAB back into VPX to update the gdi framebuffer. It really is a time saving improvement!