mjrgh / PinballY

A table browser and launcher ("front end") for virtual pinball cabinets.
Other
47 stars 22 forks source link

Add option to mute auto-repeat sounds for prev/next button presses #82

Closed byancey closed 4 years ago

byancey commented 5 years ago

This update adds an option to the Audio/Video dialog box that allow you to mute the button sound for auto-repeat events. When the prev/next or prevpage/nextpage buttons are pressed, you will hear the normal button press sound, and if held, you will hear one additional button press sound as the auto-repeat scrolling kicks in, and then additional button sounds will be muted.

This option effectively replicates the behaviour of PinballX when the next/prev buttons are held down. This also has the benefit of slightly smoother scrolling as the wheel spins.

mjrgh commented 4 years ago

I've implemented this for the next release in a slightly different way internally (same effect as far as the user is concerned).

One user-visible change, though: I didn't include the added menu command. The reason that Mute Buttons is on the menu (as well as in the options) is that general button muting is the sort of thing you might want to engage temporarily, for quieter play during at night or whenever else; whereas the repeat behavior is more of a general preference that a given user will probably want to select or not select and leave it at that. So I don't think it's a good candidate for the default menus - there should be a very high bar for commands making it onto those menus because of the usability impact of the visual clutter of extra commands. Users who do want the command on a menu can always add it with Javascript.