search

mjrgh / PinballY

A table browser and launcher ("front end") for virtual pinball cabinets.
Other
47 stars 22 forks source link

Fix table audio mute issue #83

Closed byancey closed 4 years ago

byancey commented 5 years ago

It is currently not possible to mute audio from videos independently from table audio. This results in a situation where you either get both video and table audio playing overtop of each other, or no table audio at all.

This fix separates out the options for muting video and table audio and changes the code that mutes table audio when video files are muted.

Note for mjr: Both this pull request and my pull request for muting repeat button press sounds modify the same Audio/Video dialog box. Not sure if you have an easy way to merge these changes if you pull them both in. I had to do this manually in my own workspace, so just let me know if you'd llike me to upload a merged copy of the rc file.

mjrgh commented 4 years ago

Merged for the next release (manually applied).