search

mjrusso / scoot

Keyboard-driven MacOS cursor actuator
BSD 3-Clause "New" or "Revised" License
333 stars 14 forks source link

Fix keybinding for scrolling in vi mode #36

Closed lowkahonn closed 1 year ago

lowkahonn commented 1 year ago

The keybinding for scrolling in vi mode was mistakenly configured. For example, gotta scroll down with ShiftF. This PR aims to fix that by adding a check for .control modifier

mjrusso commented 1 year ago

Thanks for this!

On first glance, I assumed that I had inadvertently broken scrolling in vi mode as part of the refactor in 0ad3e16776caef35a39ff76c5b5d7648c0c41029, but that commit didn't touch scrolling at all. Turns out that these keybindings were broken since my initial implementation 🤦