search

mjschultz / py-radix

Python radix tree implementation for IPv4 and IPv6 prefix matching.
Other
119 stars 37 forks source link

Fixed syntax/linker issues when using Microsoft Visual C++ Compiler for Python 2.7 #29

Closed xrsanet closed 7 years ago

xrsanet commented 7 years ago

I had issues when doing a pip install py-radix or manually compiling the C Extensions on a Windows machine using python setup.py build. This commit solves that issue when using MSVC++ as a target compiler.

Edit: with Python 2.7.12 64bit.

Please review.

It seems 32bit will have the same issues and requires the above merge + doing something with the inet_ntop reference in radix/_radix/radix.h.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.33% when pulling 9cf6e5f2fc451cc2386c1922be1f0d30fb3df953 on xrsanet:master into 7ba9228602f07b309c339fc1a103ad0540bb02e0 on mjschultz:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.33% when pulling 28d7790f71c73b6ea531c2a5cdf3ab59f4c282ed on xrsanet:master into 7ba9228602f07b309c339fc1a103ad0540bb02e0 on mjschultz:master.

mjschultz commented 7 years ago

Unfortunately I don't have access to a Windows box anymore and I haven't quite gotten the AppVeyor builder to work yet, so I'll have to trust the little output from AppVeyor and your judgement on getting it to work.

So, thanks! Please let me know if you have any other problems, I'll take another stab at getting AppVeyor to work when I can.

mjschultz commented 7 years ago

Release as py-radix==0.9.7