search

mjstraughan / CubingHistory

A history of twisty puzzle contributions.
http://cubinghistory.com
1 stars 1 forks source link

performance issues #12

Open bcube2 opened 1 month ago

bcube2 commented 1 month ago

I know it´s not a priority for you right now and I don´t want to overwhelm you, but later you might want to address performance issues. For example, https://www.cubinghistory.com/World%20Records/WorldRecordSingles2H takes a very long time to load, causing that the first simulator is laggy in animation on my mobile phone.

Performance summary can be seen e.g. in an automatic performace test tool such as PageSpeed Insights.

mjstraughan commented 1 month ago

I definitely noticed and it has been annoying me. Not yet sure if it is the large number of YouTube embeds, simulators, or the combination. I'll do some testing a little later and see if placing the videos in a collapsible improves the performance. I originally planned to have all or most of the videos in collapsibles anyway.

mjstraughan commented 1 month ago

Using that recommended tool, it looks like it is the YouTube embeds.

bcube2 commented 1 month ago

Not yet sure if it is the large number of YouTube embeds, simulators, or the combination.

In PageSpeed Insights, you can test a page with 142 simulators and no performance optimization whatsoever: https://bcube2.github.io/old_waterman_method/stage3.html or a page with less simulators but also some youtube videos of former WRs with some basic performance optimization: https://hlavolam.maweb.eu/rubiks-cube-3x3x3 which should result in a conclusion that a lot of ACJS simulators even without any kind of performance optimization is not really an issue in terms of performance.

mjstraughan commented 1 month ago

I added loading="lazy" to all YouTube embeds on the records pages. The performance is better for me and the embeds on PageSpeed Insights is showing a loading time of 0 for most. Still not perfect I think. How is it on your side?

bcube2 commented 1 month ago

How is it on your side?

Similar - I am lazy loading all iframes and some images.

On my end, according to https://tools.pingdom.com/ for https://www.cubinghistory.com/World%20Records/WorldRecordSingles2H tested from San Francisco, load time is more than 20 s, number of requests is more than 750, and page size is 27.8 MB. I would expect much lower values for all those parameters.