mjswart-d2l / CollectWaitStats

Collect wait statistics from SQL Server's system views.
12 stars 5 forks source link

Change CollectedDate to server time instead of UTC? #9

Open mjswart-d2l opened 3 years ago

mjswart-d2l commented 3 years ago

I'm not sure... Have to think about this one

fatherjack commented 3 years ago

I think I would go for local time value in the CollectionDate as most of this information is going to be local to one server and therefore in one timezone. Cases of comparing this sort of information in servers from different timezones is perhaps less likely to be a common occurrence. You could add a second column CollectionDateUTC that is simply a calculated column based on the CollectionDate values.

mjswart-d2l commented 3 years ago

It's hard to say... There's a lot of value in keeping the same timezone across servers. For us, that timezone is always UTC. We regularly consolidate lots of data into one place for just this purpose.

UTC can't be a calculated column. We've learned the hard way that the timezone of the server hosting a database is not as permanent as you'd think.

Then again, I'm building this project for the community, not just myself, so I have to think about this one.